Fix pkg-config files #1890
Merged
Fix pkg-config files #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1890 +/- ##
==========================================
- Coverage 78.50% 78.47% -0.03%
==========================================
Files 585 585
Lines 99516 99516
Branches 14244 14243 -1
==========================================
- Hits 78122 78097 -25
- Misses 20759 20783 +24
- Partials 635 636 +1 ☔ View full report in Codecov by Sentry. |
samuel40791765
approved these changes
Sep 30, 2024
justsmth
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Discovered that our pkg-config description files had hard-coded libdir and includedir values that could differ from the actual installation directory values.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.